Renesas: Smartbond: Update MIPI DBI driver to work with PM (update) #72819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: Renesas SmartBond
ioannis-karachalios
force-pushed
the
da1469x-pm-mipi-dbi-update
branch
from
6b9059b
to
a7aaf4a
Compare
Done |
blauret
previously approved these changes
May 16, 2024
danieldegrasse
previously approved these changes
May 16, 2024
ydamigos
reviewed
May 17, 2024
| /* | ||
| * Although PD_SYS should already be turned on, make sure LCD controller's | ||
| * power domain is up and running before accessing the display block. | ||
| * Acquiring PD_COM is mandatory when in PM runtime mode. |
There was a problem hiding this comment.
Suggested change
| * Acquiring PD_COM is mandatory when in PM runtime mode. | |
| * Acquiring PD_SYS is mandatory when in PM runtime mode. |
ydamigos
reviewed
May 17, 2024
| @@ -497,11 +497,24 @@ static int mipi_dbi_smartbond_pm_action(const struct device *dev, enum pm_device | |||
| /* Sleep is only allowed when there are no active LCDC operations */ | |||
| if (!data->is_active) { | |||
| (void)mipi_dbi_smartbond_suspend(dev); | |||
| /* | |||
| * Once the display block is turned off, its power rail | |||
There was a problem hiding this comment.
Suggested change
| * Once the display block is turned off, its power rail | |
| * Once the display block is turned off, its power domain |
The power rail of a peripheral block should always be acquired/released before/after its employment even if it's known that it should already be up and running. Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
ioannis-karachalios
dismissed stale reviews from danieldegrasse and blauret
via
ddc7731
ioannis-karachalios
force-pushed
the
da1469x-pm-mipi-dbi-update
branch
from
a7aaf4a
to
ddc7731
Compare
ydamigos
approved these changes
May 17, 2024
andrzej-kaczmarek
approved these changes
May 17, 2024
blauret
approved these changes
May 17, 2024
danieldegrasse
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be a continuation of #72184