Renesas: Smartbond: RTC Driver Update #72817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: RTC
ioannis-karachalios
force-pushed
the
da1469x-rtc-update
branch
3 times, most recently
from
f0ae9b5
to
0abc423
Compare
There was a problem hiding this comment.
You could introduce the shared util
zephyr/drivers/rtc/rtc_utils.h
Line 26 in bc183d1
ioannis-karachalios
force-pushed
the
da1469x-rtc-update
branch
from
0abc423
to
db6b58a
Compare
This commit should fix the followings:
1. When an alarm event is initialized, the driver should only
consume the valid alarm fields, based on the given mask.
Otherwise, the driver should use default valid subfield
values.
2. Setting an alarm event should not return with error code
if the timer and/or calendar counters have yet to be
initialized, explicitly. Instead, a log warning should be
issued.
Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
This commit should add support for the DA1469x Pro DevKit. Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
ioannis-karachalios
force-pushed
the
da1469x-rtc-update
branch
from
db6b58a
to
96cf924
Compare
Done. The RTC controller should detect invalid alarm fields and API should return with -EINVAL. However, it should be more efficient to use the mentioned utility before accessing the RTC alarm registers. |
blauret
approved these changes
May 17, 2024
ydamigos
approved these changes
May 17, 2024
andrzej-kaczmarek
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix few RTC driver issues and add support to the RTC test suite.