Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: i2c: i2c_target_api: added single mode testcase #72802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CZKikin
Copy link

@CZKikin CZKikin commented May 15, 2024

Some drivers do not support dual mode testcase. It would be great to test both signle and dual mode, even when the drivers do support this feature.

teburd
teburd previously approved these changes May 15, 2024
@teburd teburd added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label May 15, 2024
@hakehuang
Copy link
Collaborator

hakehuang commented May 15, 2024

I would not recommend to enable test this way, as the board to board loopback testing is not that reliable, instead can you enable i2c_ram test through the ardiono_i2c? but this is not a blocking for this PR.
besides, I test below platform:
mimxrt1170_evk/mimxrt1176/cm7 for i2c_mcux_lpi2c
frdm_mcxn947/mcxn947/cpu0 for i2c_mcux_flexcomm
which all works fine.

so my recommandation would be to add the mimxrt1170_evk/mimxrt1176/cm7 and mimxrt1170_evk/mimxrt1176/cm4 in this PR as well.

@dleach02
Copy link
Member

@CZKikin, please address your CI issues

@teburd teburd dismissed their stale review May 15, 2024 14:25

a bit premature on the +1, ci needs to be fixed

@hakehuang
Copy link
Collaborator

@CZKikin add mimxrt1170_evk/mimxrt1176/cm7 overlay, but do not remove the mimxrt1170_evk@B/mimxrt1176/cm7

Some drivers do not support dual mode testcase. It would be great to test
both signle and dual mode, even when the drivers do support this feature.

Signed-off-by: Krystof Sadlik <krystof.sadlik@nxp.com>
@hakehuang
Copy link
Collaborator

board testing is PASS for all supporting platforms, but need fix the CI issue @CZKikin

@CZKikin CZKikin force-pushed the feature/i2c_single_mode_test branch from 1652832 to d93911d Compare May 29, 2024 14:53
@CZKikin CZKikin requested review from hakehuang and teburd May 30, 2024 09:54
@danieldegrasse
Copy link
Collaborator

@CZKikin you can resolve the compliance error locally by amending your commit to use the same author name as the Signed-off entry, just run the following:

$ git commit --amend --author="Krystof Sadlik <krystof.sadlik@nxp.com>"     

@teburd teburd assigned dleach02 and unassigned teburd May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: I2C Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants