-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Multi-Value support via Tuples & Struct-mapping #306
Open
HailToDodongo
wants to merge
20
commits into
wasm3:main
Choose a base branch
from
HailToDodongo:cpp_multival
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HailToDodongo
changed the title
C++ Multi-Value support via Tuples & Struct-mapping
WIP: C++ Multi-Value support via Tuples & Struct-mapping
Jan 22, 2022
HailToDodongo
changed the title
WIP: C++ Multi-Value support via Tuples & Struct-mapping
C++ Multi-Value support via Tuples & Struct-mapping
Jan 23, 2022
@HailToDodongo sorry for the huge delay. I decided to perform a maintenance release of wasm3, so I hope to review and merge PRs like this finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ Multivalue
(Needs changes from #305)
The goal is to have easy support for multi-return values in the c++ binding.
Getting the values can either be done via tuples or structure-mapping.
E.g.
or
TODOs:
Open Questions:
For unit tests, i assume
test/internal/m3_test.c
was unused since it wasn't referenced anywhere.I converted it to a catch2 test which can be run locally and in github actions.
What was the original plan for this file?