Fix potential github action smells #16508
Conversation
|
|
|
@ceddy4395 also note we're using conventional commits, you'll need to rewrite your commits using this convention (see the PR template). |
- Stop running workflows when there is a newer commit in branch - Use commit hash instead of tags for action versions - Use names for run steps - Steps should only perform a single command
|
@jeromelaban, thanks for pointing that out 🙈 |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
|
@ceddy4395 it looks like specifying the base path entirely is required: https://github.com/unoplatform/uno/actions/runs/8906593863/job/24459818384?pr=16508#step:14:49 |
|
@jeromelaban Yes I see, thanks for the feedback, I've reverted those changes. |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
working-dir Make sure all files (including new ones) are also staged
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html |
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Hey! 🙂
I want to contribute the following changes to your workflow:
These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):