capsules: spi_controller: Support read only and inline operations #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
reviewed
May 14, 2024
In order to fully implement the embedded_hal::spi::SpiDevice [1] trait we need to support a read only operation (writing 0xFF) and a single buffer read/write operation (in place transfer). This commit adds support for those two operations to the userspace capsule so we can then build embedded_hal::spi::SpiDevice support on top. 1: https://docs.rs/embedded-hal/1.0.0/embedded_hal/spi/trait.SpiDevice.html Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
force-pushed
the
alistair/embedded-rust-spi
branch
from
3d36bd6
to
a79a045
Compare
bradjc
approved these changes
May 15, 2024
|
Ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Support read only and inline read/write operations.
In order to fully implement the embedded_hal::spi::SpiDevice [1] trait we need to support a read only operation (writing 0xFF) and a single buffer read/write operation (in place transfer).
This commit adds support for those two operations to the userspace capsule so we can then build embedded_hal::spi::SpiDevice support on top.
1: https://docs.rs/embedded-hal/1.0.0/embedded_hal/spi/trait.SpiDevice.html
Testing Strategy
Implementing https://docs.rs/embedded-hal/1.0.0/embedded_hal/spi/trait.SpiDevice.html in libtock-rs
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.