capsules: tickv: invalidate may need another read #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically, the flow for set(k, v) is: 1. Try to append (k, v). 2. That fails, because k exists. 3. Try to invalidate key k. 4. Since we read the flash to find the key already existed, we don't need to read again. 5. Invalidate k. However, if k has rolled to a new page, then we will need a new read. We just need to handle that case by ignoring read not ready even for invalidate.
alistair23
approved these changes
May 10, 2024
brghena
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Typically, the flow for set(k, v) is:
However, if k has rolled to a new page, then we will need a new read. We just need to handle that case by ignoring read not ready even for invalidate.
Testing Strategy
This pull request was tested by working on the HOTP apps.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.