Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Ensure UART implements machine.Serialer #3995

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

WIP: Ensure UART implements machine.Serialer #3995

wants to merge 1 commit into from

Conversation

bgould
Copy link
Member

@bgould bgould commented Nov 11, 2023 •
edited

Updates to ensure that machine.UART implements machine.Serialer

Will resolve #3990

@bgould bgould changed the title Ensure UART implements machine.Serialer WIP: Ensure UART implements machine.Serialer Nov 11, 2023
@sago35
Copy link
Member

sago35 commented Nov 20, 2023

Error: sizes_test.go:76: could not build: could not compile: /Users/runner/work/tinygo/tinygo/src/machine/uart.go:26:18: cannot use (*UART)(nil) (value of type *UART) as Serialer value in variable declaration: *UART does not implement Serialer (wrong type for method Configure)

It looks like implementation is also needed in src/machine/machine_fe310.go.

@sago35 sago35 mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bgould @sago35