Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont round off floats while formatting #679

Merged
merged 6 commits into from
May 29, 2024
Merged

Conversation

dracarys18
Copy link
Contributor

Fixes #678

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.7%. Comparing base (4a74924) to head (50bbfab).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #679     +/-   ##
=======================================
- Coverage   97.8%   97.7%   -0.1%     
=======================================
  Files         81      83      +2     
  Lines       9378    9000    -378     
=======================================
- Hits        9169    8793    -376     
+ Misses       209     207      -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracarys18
Copy link
Contributor Author

@jhpratt Any updates on this? We are kind of blocked on this

@jhpratt
Copy link
Member

jhpratt commented May 16, 2024

Sorry, this fell through the cracks. I'll take a look soon, though I'll likely want to make some changes myself to avoid exposing anything unnecessarily.

@dracarys18
Copy link
Contributor Author

Sorry, this fell through the cracks. I'll take a look soon, though I'll likely want to make some changes myself to avoid exposing anything unnecessarily.

Sure thanks let me know that the changes are

@jhpratt jhpratt merged commit a65ef0e into time-rs:main May 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting bug on ISO8601
2 participants