-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting bug on ISO8601 #678
Comments
Odd. I've confirmed that the code as-is does what you say, so I'll definitely look into this more. |
Confirmed. This appears to be the behavior of Given that I can't rely on the standard library's implementations here, I'm going to have to manually format floats. It's doable and I'll probably get to it this weekend. |
Sure @jhpratt, I can take this up if you just give me a place where I should start looking at. |
The specific function is |
Sure I will take a look and create a PR for this. Thanks! |
Hey @jhpratt, So this can be fixed by just truncating the float number to the precision point before we pass it to formatter. Playground link for it. This would require just a one line change in |
Hi @jhpratt continuing our discussion from #674. I have created a repo to reproduce this bug here. You can try to run it and check it yourself.
This looks like this happens only when the TimePrecision is 3 here.
It looks like it's rounding off the time to 60 seconds and it's happening every minute. If I change the precision to 6 I can see it's adjusting to nano second
The text was updated successfully, but these errors were encountered: