Make Dynamic::try_cast_raw public
#866
Merged
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have a better name for |
|
Fair enough. If I could go back in time, I would propose this function be I can't think of a great name. Maybe |
|
Picking a good name is important for an API, just for that reason you just mentioned -- we can never ever change it. Let's spend a couple more days thinking up new names... there is no rush until the next release anyway... I also think |
This function is useful for error-reporting. With `try_cast`, one has to do one of the following: 1. Pre-clone the `Dynamic`. 2. Check `Dynamic::is` first, and still handle the `None` case of `try_cast`. To maintain the pattern of `_raw` for internal functions, we rename it to `try_cast_result`.
|
I have updated the name to |
|
Alright let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is useful for error-reporting. With
try_cast, one has to do one of the following:Dynamic.Dynamic::isfirst, and still handle theNonecase oftry_cast.