Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Add fuzzer to CI #790

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fuzz: Add fuzzer to CI #790

merged 1 commit into from
Dec 24, 2023

Conversation

silvergasp
Copy link
Contributor

This change will run the fuzzer's for a short period (600s, although I'm happy to change this), on each PR.

@schungx
Copy link
Collaborator

schungx commented Dec 3, 2023

Would GitHub be upset about running a fuzzer for 10min with each PR?

@silvergasp
Copy link
Contributor Author

In my experience no. I've run, these for 20-30min on github actions without any issues. From the github docs.

Job execution time - Each job in a workflow can run for up to 6 hours of execution time. If a job reaches this limit, the job is terminated and fails to complete.

Workflow run time - Each workflow run is limited to 35 days. If a workflow run reaches this limit, the workflow run is cancelled. This period includes execution duration, and time spent on waiting and approval.

@silvergasp
Copy link
Contributor Author

I guess it more comes down to how long you are willing to wait for the CI to be done, before you merge a PR.

@schungx
Copy link
Collaborator

schungx commented Dec 3, 2023

Well, sometimes I do want them merged quickly and not wait for the results of fuzzing... I suppose I can just press Merge even when the tests/fuzzing is not complete...

@silvergasp
Copy link
Contributor Author

Thoughts on this one. Worth merging or shall I close this one out?

@schungx
Copy link
Collaborator

schungx commented Dec 24, 2023

Merge it is! Why not. Fuzzing seems really useful!

@schungx schungx merged commit c1bd71e into rhaiscript:main Dec 24, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants