-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bitflags #736
Update bitflags #736
Conversation
I'd hesitate to bump dependencies unless absolutely necessary, just because it may force users to bump as well, causing a cascade. The user can always bump them to the latest version... As for version 2 of |
The generated struct by the #[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Debug, Clone, Copy)] But I did not do it for every flags though, because some did not require all those traits ... Also, the
I don't think there are any reasons to keep this dependency up to date expect to prevent future security issues (if there are any) ... and being up to date :) Feel free to close this or keep it, maybe bumping the depdendencies could be done once a major version of rhai goes out ? (if that is planned) |
Actually, I also don't see any particular reason not to bump I would not bump other dependencies since the user can bump them. So if you would only bump |
Done, I've kept back hashbrown and smallvec. Also, just in case, I've implemented the traits quoted here for all |
How about using "2" instead of "2.3"? Would lower versions cause a prob? |
If the authors of the crates keep following semantic versioning, yes it's no problem to use "2". However I had a few problems in personal projects where some maintainers would not bump major versions on breaking changes for specific reasons. I just took the habit of specifying specific versions because of that. However if you want to set to "2" then I'll set to "2" :) |
Yes I suggest setting to 2 unless there is a problematic version we'd need to avoid. |
@ltabis Have you checked setting to |
Hey @schungx. Sorry for the late update, I was away for a bit. I've set |
Hi,
I noticed that the
bitflags
dependency was out of date, so I bumped it, along withhashbrown
andsmallvec
.Most of the
bitflags!
calls seems to create internal bit flags for Rhai which aren't accessible from the public api. However, theASTFlags
is documented as accessible via the internal feature flag. Citing bitflag's 2.0 release:Is this acceptable ? If not, I'll close this PR.