-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: issue #4713 (print special float! not right) #4714
base: master
Are you sure you want to change the base?
Conversation
https://en.wikipedia.org/wiki/IEEE_754-1985, All NaNs in IEEE 754-1985 have this format: sign = either 0 or 1. A better test for double float NaN and INF:
|
this pr is more simple for me, and can cover all cases |
It's hard for me to understand the code without explaining the rationale of it in a PR, also no comments in the code. |
@bitbegin Thanks. In this PR you check those special values by patterns. While I prefer to do the checking by rules. See my first comment. A more lengthy version as below:
|
1ec06cd
to
7218fb4
Compare
No description provided.