-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rcore] Manage access to CORE.Window
through a macro to make multi-window branch easier to update
#3976
base: master
Are you sure you want to change the base?
Conversation
CORE.Window
through a macro to make multi-window branch easier to update
@@ -302,6 +302,76 @@ | |||
</Link> | |||
</ItemDefinitionGroup> | |||
<ItemGroup> | |||
<ClCompile Include="..\..\..\src\platforms\rcore_android.c"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those files required? I don't need them on my VS2022 project solution...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not required. Having them in the solution and marked as non buildable simply makes them easy to find and edit from within the IDE, instead of having to go find the files. It's purely a convenience feature for working in visual studio.
I can remove them if desired.
@@ -0,0 +1,62 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those files required? I don't need them on my VS2022 project solution...
This PR makes a subtle but pervasive change to the platform system. It routes access to the Core.Window structure through a new macro named CORE_WINDOW.
The reason for this is to help out the multi-window branch in raylib-extras.
To make this branch work, it needs a window structure per window. Right now I have to manually replace all calls to CORE.Window with CORE.Window[GetActiveWindow()], and everytime raylib updates things break. With this change, the branch can simply replace the CORE_WINDOW macro in one place and not have to hit all the places in the code and all platforms.
This change has ZERO benefit to regular raylib, and thus I understand if it's too pervasive, It would just make multi-window easier to keep in sync with main raylib.