Remove deploy dependencies from pyodide-build's pyproject.toml #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what this means, can you explain a bit further? |
hoodmane
approved these changes
May 10, 2024
Comment on lines
-1
to
-3
| # build | ||
| cmake | ||
| ruamel.yaml |
There was a problem hiding this comment.
Did these move somewhere else?
|
boto3 and moto is used to deploy build artifacts to s3, including pyodide.js, pyodide.asm.js, etc. I don't think these need to be a dependency of pyodide-build, as they have nothing to do with "building packages". So I think it is strange to have these packages declared in pyodide-build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes
[deploy]dependencies from pyodide-build, and puts them under therequirements-deploy.txtin the root directory.If these packages are defined in pyodide-build, they create a dependency that requires pyodide-build to be present in order to deploy Pyodide, so this PR removes them from pyodide-build.