Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indev): fix elastic scrolling with snapping #6230

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

kisvegabor
Copy link
Member

Earlier it was depending on the pressed object if elastic scroll is applied with snapping. Now it explicitly checks if there are more snap points and if not it switches to elastic scroll

Description of the feature or fix

A clear and concise description of what the bug or new feature is.

Notes

@kisvegabor kisvegabor marked this pull request as draft May 15, 2024 21:46
@kisvegabor kisvegabor marked this pull request as ready for review May 17, 2024 07:54
liamHowatt
liamHowatt previously approved these changes May 22, 2024
Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like solid logic to me!

src/indev/lv_indev_scroll.c Show resolved Hide resolved
src/indev/lv_indev_scroll.c Show resolved Hide resolved
Earlier it was depending on the pressed object if elastic scroll is applied with snapping.
Now it explicitly checks if there are more snap points and if not it switches to elastic scroll
@kisvegabor
Copy link
Member Author

@XuNeo @FASTSHIFT could you review this PR?

@XuNeo XuNeo merged commit 63edb43 into lvgl:master May 27, 2024
17 checks passed
@kisvegabor kisvegabor deleted the fix/snap branch May 27, 2024 06:20
@kisvegabor
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants