Update node installation to automatically install the correct versions. #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sftrabbit
suggested changes
Apr 24, 2023
DEVELOPMENT.md
Outdated
| ``` | ||
|
|
||
| The specific packages and versions are now in `package.json`. |
There was a problem hiding this comment.
Minor suggestion, but this could be understood as "After running the command, the specific packages and versions are now in package.json.". Might be better to say "This will install the necessary packages as listed in package.json."
| @@ -6,7 +6,7 @@ creates a highly compressed release build in bin of the contents of src | |||
|
|
|||
| packages used: | |||
|
|
|||
| npm i rimraf compress-images web-resource-inliner ncp gifsicle@5.3.0 concat ycssmin terser gzipper html-minifier-terser glob | |||
| npm i rimraf compress-images web-resource-inliner ncp gifsicle@5.3.0 concat ycssmin terser gzipper html-minifier-terser glob@8 | |||
There was a problem hiding this comment.
Should probably remove this line (and maybe replace it with another line saying to use npm install to install the packages listed in package.json.
There was a problem hiding this comment.
If it was my code I would probably just delete it, or replace it with a reference back to DEVELOPMENT.md. Not really my decision, but feel free if so minded.
sftrabbit
suggested changes
Apr 24, 2023
increpare
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955