switch to requestAnimationFrame() for drawing #948

pancelor · 2022-12-20T13:59:17Z

This is essentially the same code as #924, with this additional code to make sure deltatime is accurate

var prevTimestamp;
function loop(timestamp) {
    var deltatime = 0
    if (prevTimestamp !== undefined) {
        deltatime = timestamp - prevTimestamp;
    }
    prevTimestamp = timestamp

This was the solution suggested by the docs; I should have seen it and included it last time!

Warning: Be sure to always use the first argument (or some other method for getting the current time) to calculate how much the animation will progress in a frame, otherwise the animation will run faster on high refresh rate screens. Check the example below for a way to do this.

previously we assumed deltatime=17 always, but this may not be true. now, use the value that requestAnimationFrame() gives us. this follows the recommendation from MDN: https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame

as suggested in increpare#948

This reverts commit 837668e.

This reverts commit 3fb0cb5.

mainly to make this easier to port to other forks

cwboden

Sweet 👍

cwboden · 2023-05-08T06:43:33Z

src/js/globalVariables.js

@@ -35,7 +35,7 @@ var throttle_movement=false;
 var cache_console_messages=false;
 var quittingTitleScreen=false;
 var quittingMessageScreen=false;
-var deltatime=17;
+var deltatime=17; // this gets updated every frame; see loop()


Love comments like this 😁

pancelor added 2 commits December 20, 2022 05:05

use requestAnimationFrame for main loop

3fb0cb5

use actual deltatime in mainloop

837668e

previously we assumed deltatime=17 always, but this may not be true. now, use the value that requestAnimationFrame() gives us. this follows the recommendation from MDN: https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame

This was referenced Dec 20, 2022

realtime_interval and key_repeat_interval are browser-dependent #949

Open

Timing behaviour/skipping frames #925

Open

ClementSparrow added a commit to ClementSparrow/Pattern-Script that referenced this pull request Dec 28, 2022

use requestAnimationFrame rather than setInterval

c749683

as suggested in increpare#948

pancelor added 3 commits February 7, 2023 17:34

Revert "use actual deltatime in mainloop"

40417b0

This reverts commit 837668e.

Revert "use requestAnimationFrame for main loop"

038d538

This reverts commit 3fb0cb5.

redo requestAnimationFrame with simpler diff

8bed406

mainly to make this easier to port to other forks

cwboden approved these changes May 8, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch to requestAnimationFrame() for drawing #948

switch to requestAnimationFrame() for drawing #948

pancelor commented Dec 20, 2022

cwboden left a comment

cwboden May 8, 2023

switch to requestAnimationFrame() for drawing #948

Are you sure you want to change the base?

switch to requestAnimationFrame() for drawing #948

Conversation

pancelor commented Dec 20, 2022

cwboden left a comment

Choose a reason for hiding this comment

cwboden May 8, 2023

Choose a reason for hiding this comment