Add WGPUDeviceLostReason_Unknown, deprecate _Undefined #21914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe for this PR as well, unknown should be value 0x1, and destroyed should be value 0x2 |
I have redefined the values for |
|
looks good to me, but I don't have review permissions |
|
Hello Kai Ninomiya, could you please take a moment to review this PR? Thanks. |
kainino0x
reviewed
May 15, 2024
| @@ -324,8 +324,8 @@ typedef enum WGPUCullMode { | |||
| } WGPUCullMode WGPU_ENUM_ATTRIBUTE; | |||
|
|
|||
| typedef enum WGPUDeviceLostReason { | |||
| WGPUDeviceLostReason_Undefined = 0x00000000, | |||
| WGPUDeviceLostReason_Destroyed = 0x00000001, | |||
| WGPUDeviceLostReason_Unknown = 0x00000001, | |||
There was a problem hiding this comment.
We need to avoid breaking changes for now, so please add:
WGPUDeviceLostReason_Undefined = 0x00000001,
(with the same value 1 as Unknown)
and same elsewhere
There was a problem hiding this comment.
I have uploaded a new commit, please review it.
Please check https://issues.chromium.org/issues/42241081 for more information and progress. webgpu-headers PR: webgpu-native/webgpu-headers#288.
kainino0x
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check
https://issues.chromium.org/issues/42241081 for
more information and progress.
webgpu-headers PR:
webgpu-native/webgpu-headers#288.
@kainino0x @austinEng