Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AsyncDrawTarget trait with associated async_draw feature flag #747

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ValouBambou
Copy link

Thank you for helping out with embedded-graphics development! Please:

  • Check that you've added passing tests and documentation
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

This PR tries to fix #622 by implementing a first draft of an AsyncDrawTarget trait to enable some async primitives for DMA, like what exists with embassy, for example.

@TG-Techie
Copy link

This would be great to have!

@ValouBambou
Copy link
Author

I was quickly iterating in order to test it on some use case, so there are a lot of duplicates and I didn't take the time to do something cleaner with a macro like maybe_async. So when someone wants this to be merged, ping me and I will try to improve it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support async version of DrawTarget.
2 participants