Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounding box for Arc/Sector #524

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jamwaffles
Copy link
Member

Thank you for helping out with embedded-graphics development! Please:

  • Check that you've added passing tests and documentation
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
  • Run rustfmt on the project
  • Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description

Closes #441
Closes #405

@jamwaffles jamwaffles changed the title Fix bounding box for Arc Fix bounding box for Arc/Sector Jan 14, 2021
@jamwaffles jamwaffles force-pushed the fix-arc-sector-bounding-box-2 branch 2 times, most recently from b25f953 to 997e45a Compare January 15, 2021 16:47
@rfuest
Copy link
Member

rfuest commented Apr 19, 2021

Do you want to finish this PR or should I give it a try?

@jamwaffles
Copy link
Member Author

It would be great if you could take a crack at it.

@cedeber cedeber mentioned this pull request Oct 14, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounding boxes for Arc and Sector don't take the angles into account
2 participants