Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounding boxes for Arc and Sector don't take the angles into account #405

Open
rfuest opened this issue Jul 20, 2020 · 5 comments · May be fixed by #441, #524 or #698
Open

Bounding boxes for Arc and Sector don't take the angles into account #405

rfuest opened this issue Jul 20, 2020 · 5 comments · May be fixed by #441, #524 or #698
Labels
bug Something isn't working
Projects
0.7.0-alpha.2

Comments

@rfuest
Copy link
Member

rfuest commented Jul 20, 2020

The Dimensions trait impl for Arc and Sector returns the same bounding box as a circle with the same top_left and diameter. But the bounding box can be much smaller if angle_sweep is small.
@jamwaffles jamwaffles added the bug Something isn't working label Jul 21, 2020
@jamwaffles jamwaffles added this to To do in 0.7.0-alpha.1 via automation Jul 21, 2020
@jamwaffles jamwaffles self-assigned this Aug 10, 2020
@jamwaffles jamwaffles moved this from To do to In progress in 0.7.0-alpha.1 Aug 10, 2020
@jamwaffles jamwaffles removed their assignment Aug 11, 2020
@jamwaffles
Copy link
Member

This is trickier than I first thought so I've unassigned myself if someone else wants to take a look.

@jamwaffles jamwaffles mentioned this issue Aug 11, 2020
Closed
@jamwaffles jamwaffles moved this from In progress to To do in 0.7.0-alpha.1 Aug 11, 2020
@rfuest rfuest mentioned this issue Aug 17, 2020
Merged
5 tasks
@jamwaffles
Copy link
Member

Note: #431 (comment)

Remember to fix styled bounding box for arc/sector also.

@jamwaffles jamwaffles linked a pull request Sep 19, 2020 that will close this issue
Draft
7 tasks
@jamwaffles jamwaffles moved this from To do to In progress in 0.7.0-alpha.1 Sep 19, 2020
@jamwaffles jamwaffles removed this from In progress in 0.7.0-alpha.1 Sep 19, 2020
@jamwaffles jamwaffles added this to To do in 0.7.0-alpha.2 via automation Sep 19, 2020
@jamwaffles jamwaffles mentioned this issue Nov 15, 2020
Merged
4 tasks
@jamwaffles jamwaffles linked a pull request Jan 14, 2021 that will close this issue
Draft
4 tasks
@cedeber
Copy link

cedeber commented Sep 30, 2022

Hello, any news about this one? I've seen you've started something on another branch (outdated now) but stopped at some point. I would like to see it fixed as I am currently doing crazy stuff with this crate: https://github.com/cedeber/framebuffer-worker. I could have a look if you'll please update the branch - so that I can fork - and give me some advices where to continue.

@jamwaffles
Copy link
Member

I'd be very happy if someone else wanted to take a look at fixing this. I did a quick skim of my PR and it's so out of date I think it's better to start from scratch, perhaps using that PR as a reference instead of a base to fork from.

@cedeber
Copy link

cedeber commented Oct 1, 2022

Okey, let's give it a try.

@cedeber cedeber linked a pull request Oct 11, 2022 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
0.7.0-alpha.2
  
To do
Milestone
No milestone
3 participants
@rfuest @jamwaffles @cedeber