Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using latest version of the frontend plugin= #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fe-lix-
Copy link

@fe-lix- fe-lix- commented Oct 25, 2022

Making the installation process work on ARM64 mac.

Description

The current version of the frontend-maven-plugin detect correcly the CPU of M1 Mac as ARM64 and tries to download node with that architecture. Node has not been complied for darwin-arm64 before v16. So using a newer version of the module we can download the darwin-x64 binaries that are compatible.

Motivation and Context

Get the sample to work on Mac M1, M2.

How Has This Been Tested?

Tested on my Mac M1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant