Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExprExplodedBlocks - fix not being able to remove #6655

Merged
merged 10 commits into from
Jun 1, 2024
Merged

ExprExplodedBlocks - fix not being able to remove #6655

merged 10 commits into from
Jun 1, 2024

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to fix an issue with not being able to remove blocks from the exploded block list.
This is standard behaviour in Bukkit, but Skript "lists" don't allow for this action, which I've seen many many people complain about.

Target Minecraft Versions: any
Requirements: none
Related Issues: none

Fusezion
Fusezion approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna say I was suppose to be fixed in #3990 but like much of those prs from then it staled out all for this fix.

@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. 2.8 Targeting a 2.8.X version release patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels May 7, 2024
APickledWalrus
APickledWalrus requested changes May 8, 2024
View reviewed changes
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if this might be better to target feature? does attempting to modify the list (remove, add, etc.) parse currently?

src/main/java/ch/njol/skript/expressions/ExprExplodedBlocks.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/expressions/ExprExplodedBlocks.java Outdated Show resolved Hide resolved
@ShaneBeee
Copy link
Contributor Author

i wonder if this might be better to target feature? does attempting to modify the list (remove, add, etc.) parse currently?

It doesn't appear to error (which is odd) but absolutely nothing happens.

@Moderocky Moderocky merged commit 0c73369 into SkriptLang:dev/patch Jun 1, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the fix/exploded-blocks-remove branch June 2, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fusezion Fusezion Fusezion approved these changes

@sovdeeth sovdeeth sovdeeth approved these changes

@Moderocky Moderocky Moderocky approved these changes

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@UnderscoreTud UnderscoreTud UnderscoreTud approved these changes

Assignees
No one assigned
Labels
2.8 Targeting a 2.8.X version release enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ShaneBeee @sovdeeth @Moderocky @APickledWalrus @Fusezion @UnderscoreTud