Improve /skript subcommand help colours #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
May 6, 2024
sovdeeth
added
enhancement
|
Moderocky
approved these changes
May 6, 2024
|
@Moderocky re-run workflows pls? |
sovdeeth
added
the
patch-ready
|
Before this is merged, might I talk about the 2 different colours? |
Agreed that we should choose one for consistency. |
They are at a different level in the command tree, which is why they originally had different colours |
The other subcommands already use a different colour from the top-level command. Cyan is consistent with them. |
AyhamAl-Ali
approved these changes
May 7, 2024
UnderscoreTud
approved these changes
May 31, 2024
Moderocky
force-pushed
the
enhancement/better-help-colours
branch
from
485ee75
to
855dc69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the colour used for the arguments of
/skriptsubcommands in help pages from dark red to dark cyan. Dark cyan is a less jarring colour and also matches the output from/skript info.