Codegen JVM: Use IXOR to optimize materialization of BooleanNegation #5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udalov
reviewed
May 13, 2024
compiler/ir/backend.jvm/codegen/src/org/jetbrains/kotlin/backend/jvm/intrinsics/Not.kt
Outdated
Show resolved
Hide resolved
scaventz
force-pushed
the
KT-65357-negatedStringCompare.kt
branch
from
e246fc4
to
a8b7891
Compare
pyos
reviewed
May 14, 2024
| value.materializeAt(Type.BOOLEAN_TYPE, codegen.context.irBuiltIns.booleanType, false) | ||
| mv.iconst(1) | ||
| mv.xor(Type.INT_TYPE) | ||
| StackValue.coerce(Type.BOOLEAN_TYPE, target, mv) |
There was a problem hiding this comment.
the fact that you're not using irTarget here seems suspicious, because it could be an inline class type. wasn't there a 5-argument version of coerce?
There was a problem hiding this comment.
Is that possible? Can you please give me an example where irTarget is an inline class type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: KT-65357