-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session token "safety window" when refreshing #22503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
br41nslug
commented
May 15, 2024
br41nslug
commented
May 15, 2024
br41nslug
changed the title
[WIP] Session token "safety window" when refreshing
Session token "safety window" when refreshing
May 15, 2024
…directus into session-sliding-window
Co-authored-by: Hannes Küttner <4376726+hanneskuettner@users.noreply.github.com>
licitdev
reviewed
May 15, 2024
Co-authored-by: ian <licitdev@gmail.com>
joselcvarela
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✅
This comment was marked as resolved.
This comment was marked as resolved.
paescuj
reviewed
May 20, 2024
paescuj
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a "safety window" keeping the old token active for a short amount of time to resolve in-flight requests using the previous token.
As described here https://cheatsheetseries.owasp.org/cheatsheets/Session_Management_Cheat_Sheet.html#renewal-timeout
Fixes #22360
Scope
What's changed:
directus_sessions
table used to link refreshed sessions to their successor.Potential Risks / Drawbacks
Review Notes / Questions
SESSION_REFRESH_GRACE_PERIOD
?