Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch-build-bottle: add provenance step #171819

Merged
merged 1 commit into from
May 16, 2024

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented May 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is a demonstration of one approach; another approach is to design a reusable workflow to be shared across different uploading workflows, although that's going to be more involved due to a need to re-upload/uniformly stage the bottle artifacts.

I'm not sure if there's a straightforward way to test this locally, unfortunately.

Behavioral changes:

  • Changed the ~/bottles download location to $GITHUB_WORKSPACE/bottles and abstracted it into the environment
  • Added a build provenance generation step, matching the one in publish-commit-bottles.yml

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw self-assigned this May 15, 2024
@woodruffw woodruffw requested review from MikeMcQuaid and a team as code owners May 15, 2024 19:34
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels May 15, 2024
@woodruffw woodruffw requested review from Bo98 and carlocab May 15, 2024 19:35
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is simplest

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@carlocab carlocab added this pull request to the merge queue May 16, 2024
@woodruffw
Copy link
Member Author

Thanks all! I'll keep an eye on this for problems, and follow up with the other workflows once this one is confirmed good.

Merged via the queue into master with commit e2dab96 May 16, 2024
19 checks passed
@carlocab carlocab deleted the ww/attest-dispatch-build-bottle branch May 16, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants