-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tenv 1.11.2 #171699
tenv 1.11.2 #171699
Conversation
ef35c94
to
b2f532a
Compare
b2f532a
to
8e5eb95
Compare
Now build fails, because Atmos is available in tenv v.1.11.0 |
btw. why version is not updating automatically in master? I wanted to rebase to solve issues in this mr, but master does not contain 1.11. |
No versions are updated automatically in master. All updates are done by pull request. |
@SMillerDev it's really strange, because @chenrui333 told us that it will be updated automatically. We did automatic update of our tap by goreleaser. |
hi @chenrui333 , can you help us here? |
854daaf
to
225e6c4
Compare
@SMillerDev @chenrui333 what's wrong with commit style? |
225e6c4
to
093d412
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Also add atmos support
093d412
to
9711552
Compare
Looks like that we need to delete conflict from these formulas. tenv, tfenv, tgenv install binaries to separate directories and it's fine to use both of them at the same time, but if you think that it will be better to leave conflict as it, i can return it |
No, we shouldn't delete the conflicts from those formulae. The CI failure from earlier happened precisely because the conflicts were deleted, so we should keep them as-is. |
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?