Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenv 1.11.2 #171699

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

kvendingoldo
Copy link
Contributor

@kvendingoldo kvendingoldo commented May 14, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • tenv does not conflict with tfenv and tgenv, because both of these tools install Terraform/Terragrunt binaries to their own folders
  • tenv conflicts with atmos, because it wrap it up as well as OpenTofu/Terraform/Terragrunt

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 14, 2024
@github-actions github-actions bot added go Go use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request labels May 14, 2024
@kvendingoldo
Copy link
Contributor Author

Now build fails, because Atmos is available in tenv v.1.11.0

@kvendingoldo
Copy link
Contributor Author

btw. why version is not updating automatically in master? I wanted to rebase to solve issues in this mr, but master does not contain 1.11.

@SMillerDev
Copy link
Member

btw. why version is not updating automatically in master? I wanted to rebase to solve issues in this mr, but master does not contain 1.11.

No versions are updated automatically in master. All updates are done by pull request.

@kvendingoldo
Copy link
Contributor Author

@SMillerDev it's really strange, because @chenrui333 told us that it will be updated automatically. We did automatic update of our tap by goreleaser.

@kvendingoldo
Copy link
Contributor Author

hi @chenrui333 , can you help us here?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 19, 2024
@kvendingoldo kvendingoldo force-pushed the add-atmos-support-to-tenv branch 2 times, most recently from 854daaf to 225e6c4 Compare May 19, 2024 15:58
@carlocab carlocab changed the title feat: update tenv formula tenv 1.11.2 May 19, 2024
@kvendingoldo
Copy link
Contributor Author

@SMillerDev @chenrui333 what's wrong with commit style?

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 19, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab
Copy link
Member

tfenv and tgenv are failing to install due to conflict with tenv. Looks like the existing conflicts_with are correct.

@carlocab carlocab added the ready to merge PR can be merged once CI is green label May 19, 2024
Formula/t/tenv.rb Show resolved Hide resolved
@kvendingoldo
Copy link
Contributor Author

@carlocab

tfenv and tgenv are failing to install due to conflict with tenv. Looks like the existing conflicts_with are correct.

Looks like that we need to delete conflict from these formulas. tenv, tfenv, tgenv install binaries to separate directories and it's fine to use both of them at the same time, but if you think that it will be better to leave conflict as it, i can return it

@carlocab carlocab requested a review from p-linnane May 20, 2024 02:58
@carlocab
Copy link
Member

@carlocab

tfenv and tgenv are failing to install due to conflict with tenv. Looks like the existing conflicts_with are correct.

Looks like that we need to delete conflict from these formulas. tenv, tfenv, tgenv install binaries to separate directories and it's fine to use both of them at the same time, but if you think that it will be better to leave conflict as it, i can return it

No, we shouldn't delete the conflicts from those formulae. The CI failure from earlier happened precisely because the conflicts were deleted, so we should keep them as-is.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 20, 2024
Merged via the queue into Homebrew:master with commit 02425ce May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants