Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HR] Reloading a control does apply outer attached properties #16723

Open
ArchieCoder opened this issue May 14, 2024 · 3 comments · May be fixed by #16754
Open

[HR] Reloading a control does apply outer attached properties #16723

ArchieCoder opened this issue May 14, 2024 · 3 comments · May be fixed by #16754
Assignees
Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@ArchieCoder
Copy link
Contributor

Current behavior

When changing a property in StatusBar.xaml in a debugging session, the StatusBar will expand at max height

Hotreload.mp4

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

1- Open the project Test.zip
2- Start the debugging session
3- Open StatusBar.xaml then change line 12 to Background="Red" then click Save.

The whole StatusBar will goes max height.

Workaround

No response

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia

NuGet package version(s)

No response

Affected platforms

Skia (WPF)

IDE

No response

IDE version

Latest VS Code

Relevant plugins

No response

Anything else we need to know?

No response

@ArchieCoder ArchieCoder added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels May 14, 2024
@ArchieCoder ArchieCoder changed the title Hot reload with Desktop/Skia does not Hot reload with Desktop/Skia does not render as expected May 14, 2024
@jeromelaban
Copy link
Member

jeromelaban commented May 14, 2024

Thanks the for the report!

It looks like we're not properly re-applying the attached properties from the creating site when elements are reloaded.

<presentation:StatusBar
    Grid.Row="1" />

@Youssef1313 Youssef1313 added the area/hot-reload Categorizes an issue or PR as relevant to hot reload label May 15, 2024
@jeromelaban jeromelaban changed the title Hot reload with Desktop/Skia does not render as expected [HR] Reloading a control does apply outer attached properties May 15, 2024
@Youssef1313
Copy link
Member

@ArchieCoder The attached repro project is different from the code in the video. I can't repro with the attached project. Can you check if the issue happens in the attached project, and if so, mention the line number you're modifying?

@Youssef1313
Copy link
Member

My bad, I can reproduce it now. Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants