Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Padding interaction with borders and border backgrounds #16705

Closed
ramezgerges opened this issue May 13, 2024 · 4 comments
Closed

Investigate Padding interaction with borders and border backgrounds #16705

ramezgerges opened this issue May 13, 2024 · 4 comments
Assignees
@ramezgerges
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification

Comments

@ramezgerges
Copy link
Contributor

Current behavior

Currently, the padding on an IBorderInfoProvider is not used to calculate the numbers for the border shape and the border background. A quick attempt found some differences between WinUI and Uno (at least skia) when Padding is added. This should be investigated after #16562 merges

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@ramezgerges ramezgerges added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 13, 2024
@ramezgerges ramezgerges self-assigned this May 13, 2024
@MartinZikmund
Copy link
Member

This also should take BackgroundSizing property into account

@Youssef1313
Copy link
Member

I thought padding is only considered during measure/arrange and shouldn't have any impact elsewhere 😕

@Youssef1313
Copy link
Member

@ramezgerges Can you extend the issue for exact scenario that's currently broken?

@ramezgerges
Copy link
Contributor Author

The BorderVisualClipping sample used to do some weird stuff if you added a Padding to the elements, but I'm testing it now and it seems to be... fine? I will close for now until I find an actual problem.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramezgerges ramezgerges

Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinZikmund @Youssef1313 @ramezgerges