Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor formatting issues #103

Open
schungx opened this issue Sep 5, 2022 · 4 comments
Open

Minor formatting issues #103

schungx opened this issue Sep 5, 2022 · 4 comments
Labels
A-fmt Area: Formatter bug Something isn't working

Comments

@schungx
Copy link
Collaborator

schungx commented Sep 5, 2022

switch x {
  _ => x
}

get formatted to:

switch x {
  x => x
}
@tamasfe tamasfe added bug Something isn't working A-fmt Area: Formatter labels Sep 5, 2022
@schungx
Copy link
Collaborator Author

schungx commented Oct 26, 2022

One nit-pick: For default case, it puts two spaces after the underscore instead of one:

image

@tamasfe tamasfe reopened this Oct 26, 2022
@schungx schungx changed the title Incorrect formatting for default action in switch Minor formatting issues Oct 26, 2022
@schungx
Copy link
Collaborator Author

schungx commented Oct 26, 2022

Since we're at it, here are a few more:

fn add(a, b) {
    a + b // comment
}

Result:

fn add(a, b) {
    a + b
}

The comment is gone.

@schungx
Copy link
Collaborator Author

schungx commented Oct 26, 2022

fn add(a, b) {
    a + b; // a very very very looooooooonnnnnng long long long long long long comment
}

is formatted to:

fn add(a, b) {
    a
        + b; // a very very very looooooooonnnnnng long long long long long long comment
}

If a line comment is too long, the item gets moved to the second line, which looks strange.

@schungx
Copy link
Collaborator Author

schungx commented Oct 26, 2022

image

Missing space before line comment if it is right after an open {.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fmt Area: Formatter bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants