Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhai fmt should honor tabsize #101

Open
schungx opened this issue Sep 4, 2022 · 2 comments
Open

rhai fmt should honor tabsize #101

schungx opened this issue Sep 4, 2022 · 2 comments
Labels
A-LSP Area: LSP A-vscode Area: VS Code extension E-Easy enhancement

Comments

@schungx
Copy link
Collaborator

schungx commented Sep 4, 2022 •
edited

The formatter should honor the default Rhai tab-size:

"[rhai]": {
    "editor.tabSize": 4
}

unless explicitly overwritten, I suppose.

Right now it auto-formats to 2 spaces.
@tamasfe
Copy link
Member

tamasfe commented Sep 4, 2022

Weird, if you change the tabs for a file, it does. I guess we'll have to manually read this config in the language server.

@tamasfe tamasfe added enhancement A-vscode Area: VS Code extension A-LSP Area: LSP E-Easy labels Sep 4, 2022
@schungx
Copy link
Collaborator Author

schungx commented Sep 4, 2022

That's correct. I can manually change the tab setting for an individual file and rhai fmt will honor it. However, if I don't do that, it somehow defaults to 2 spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LSP Area: LSP A-vscode Area: VS Code extension E-Easy enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schungx @tamasfe