Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.26.0 #4713

Closed
1 task done
hoodmane opened this issue Apr 22, 2024 · 11 comments
Closed
1 task done

Release 0.26.0 #4713

hoodmane opened this issue Apr 22, 2024 · 11 comments
Milestone

Comments

@hoodmane
Copy link
Member

hoodmane commented Apr 22, 2024

It's about time to release v0.26.0. I'd like to include memory snapshots, I think the bindings #4699 can wait.
@ryanking13 anything you want to get in?

  • enable xgboost
@ryanking13
Copy link
Member

Sounds good. I need to enable xgboost before the release. I have no other thing I want to include.

include memory snapshots

Is it stable enough to be added? Or do we want to add it privately without making a public API?

@ryanking13 ryanking13 added this to the 0.26.0 milestone Apr 23, 2024
@hoodmane
Copy link
Member Author

I would like to add it as public but marked experimental.

@ryanking13
Copy link
Member

I would like to add it as public but marked experimental.

Sounds good!

@hoodmane
Copy link
Member Author

hoodmane commented May 7, 2024

I think we can go ahead and release with what we have. I guess we should draw up some release notes.

@ryanking13
Copy link
Member

Good! Let's make a release before PyCon, if possible.

@hoodmane
Copy link
Member Author

Two problems:

  1. docs didn't deploy
  2. Update cross-build metadata file failed

I can fix docs.

@agriyakhetarpal
Copy link
Contributor

agriyakhetarpal commented May 27, 2024

For (2), I checked and both the workflow and the tools/update_cross_build_releases.py seem okay to me, it worked locally with an environment variable. So the only reasonable explanation is that the environment variable did not percolate to the steps after it.

@agriyakhetarpal
Copy link
Contributor

Found the error: it should have been

echo "VERSION=${{ github.event.inputs.version }}" >> $GITHUB_ENV

i.e., missing an extra > character

@agriyakhetarpal
Copy link
Contributor

agriyakhetarpal commented May 27, 2024

Never mind – #4808 fixed it already (edit: okay, it did not)

@hoodmane
Copy link
Member Author

Okay I fixed the docs.

@ryanking13
Copy link
Member

Thanks for finishing the release!

Update cross-build metadata file failed

I'll update the metadata file manually. It is not yet used, so it is not an big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants