Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set custom prompt with certain characters #53

Open
eliminmax opened this issue Nov 25, 2022 · 3 comments
Open

Can't set custom prompt with certain characters #53

eliminmax opened this issue Nov 25, 2022 · 3 comments

Comments

@eliminmax
Copy link

Prompts with escape sequences to add color, or with symbols from Nerd Fonts, cause oh to print "invalid prompt" followed by a blank line, then exit.

@michaelmacinnis
Copy link
Owner

This is due to oh using github.com/peterh/liner:
https://github.com/peterh/liner/blob/master/common.go#L66
peterh/liner#135

@eliminmax
Copy link
Author

I see. That sucks, but it doesn't seem to explain the issue with symbols from Nerd Fonts - they're just regular characters, which the font provides glyphs for.

@eliminmax
Copy link
Author

Also should probably mention - if oh exits due to this issue, it returns a successful exit code (exit code 0). Given that this is only really an issue with interactive usage, it's probably not a big deal, but figured I'd at least make a note of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants