Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Don't give up when missing the initial transmit window #77

Open
jonas-schievink opened this issue Sep 28, 2019 · 0 comments
Open

Don't give up when missing the initial transmit window #77

jonas-schievink opened this issue Sep 28, 2019 · 0 comments
Labels
area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) good first issue Call for participation: Good for newcomers status: needs code An implementation or a bugfix need to be written type: bug Something isn't behaving as intended
Milestone

Comments

@jonas-schievink
Copy link
Owner

Currently the link layer will abort the connection when it does not receive the initial connect event:

// Master did not transmit the first packet during this transmit window.
// TODO: Move the transmit window forward by the `connInterval`.
// (do we also need to hop channels here?)
self.conn_event_count += Wrapping(1);
trace!("missed transmit window");
Err(())

This shouldn't happen. Instead, we should do what the comment suggests (and check it against the spec).

The effect of this bug is that establishing a connection can spuriously fail, so this is a reliability issue.

@jonas-schievink jonas-schievink added type: bug Something isn't behaving as intended status: needs code An implementation or a bugfix need to be written area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) labels Sep 28, 2019
@jonas-schievink jonas-schievink added this to the 0.1.0 milestone Sep 28, 2019
@jonas-schievink jonas-schievink added the good first issue Call for participation: Good for newcomers label Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: link layer Code Area: BLE Link Layer (establishing and maintaining connections, encryption, etc) good first issue Call for participation: Good for newcomers status: needs code An implementation or a bugfix need to be written type: bug Something isn't behaving as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant