{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":143455116,"defaultBranch":"main","name":"filament","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-08-03T17:26:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718133675.0","currentOid":""},"activityList":{"items":[{"before":"7293057c203d4dee26547047dc86f750fe8fbcb5","after":null,"ref":"refs/heads/pf/gltfio-fix-extended-default-color","pushedAt":"2024-06-11T19:21:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"}},{"before":"9917d4b7d9466b3add2018f0518b8febb55e7bff","after":"43331d04e506b88dea9b1355267fe02a9145bfff","ref":"refs/heads/main","pushedAt":"2024-06-11T19:21:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"gltfio: [extended] Fix generated color default (#7917)\n\nFixes #7905","shortMessageHtmlLink":"gltfio: [extended] Fix generated color default (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344923529\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/filament/issues/7917\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/filament/pull/7917/hovercard\" href=\"https://github.com/google/filament/pull/7917\">#7917</a>)"}},{"before":"ec44c4a1573d88b539b411e5f37f818ca57c638a","after":"5d5f53e6e32417f3bb9061d4f5bb2fc7ad6ee41b","ref":"refs/heads/rc/1.52.3","pushedAt":"2024-06-11T16:18:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bejado","name":"Ben Doherty","path":"/bejado","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5298046?s=80&v=4"},"commit":{"message":"Acquire a mutex before releasing CAMetalDrawables on main thread. (#7888)\n\nPresentDrawable was moved to main thread by default in google#7535 and stopped\r\nmost crashes when a drawable is released. But there still appears to be crashes\r\nif a drawable is released on main thread at the same time that -nextDrawable is\r\ncalled from the Filament render thread. (It's likely that the drawable pool in\r\nCAMetalLayer is completely non-thread-safe.)\r\n\r\nSo, add a mutex to the swapchain and always acquire it before creating or\r\nreleasing a CAMetalDrawable.\r\n\r\nUsers can opt out of this behavior by passing\r\n-DFILAMENT_LOCK_METAL_DRAWABLE_POOL=0.","shortMessageHtmlLink":"Acquire a mutex before releasing CAMetalDrawables on main thread. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2324116393\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/filament/issues/7888\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/filament/pull/7888/hovercard\" href=\"https://github.com/google/filament/pull/7888\">#7888</a>"}},{"before":"553b1ee8d7ed9bf6c57a90f7751ae71f00449845","after":"7293057c203d4dee26547047dc86f750fe8fbcb5","ref":"refs/heads/pf/gltfio-fix-extended-default-color","pushedAt":"2024-06-11T00:30:27.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Merge branch 'main' into pf/gltfio-fix-extended-default-color","shortMessageHtmlLink":"Merge branch 'main' into pf/gltfio-fix-extended-default-color"}},{"before":null,"after":"470da038bb9df18843e544cd6ee1b5508f9d558c","ref":"refs/heads/pf/vk-refactor-transition","pushedAt":"2024-06-11T00:24:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"vk: refactor layout transition","shortMessageHtmlLink":"vk: refactor layout transition"}},{"before":"9592807332a190a94e645b7acae6e3d9c8710ab1","after":"553b1ee8d7ed9bf6c57a90f7751ae71f00449845","ref":"refs/heads/pf/gltfio-fix-extended-default-color","pushedAt":"2024-06-10T22:03:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"gltfio: [extended] Fix generated color default\n\nFixes #7905","shortMessageHtmlLink":"gltfio: [extended] Fix generated color default"}},{"before":"0ab2181a43b2ba34fc1cf18239ed807561e00c4a","after":"9592807332a190a94e645b7acae6e3d9c8710ab1","ref":"refs/heads/pf/gltfio-fix-extended-default-color","pushedAt":"2024-06-10T22:03:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"gltfio: [extended] Fix generated color default\n\nFixes: 7905","shortMessageHtmlLink":"gltfio: [extended] Fix generated color default"}},{"before":null,"after":"0ab2181a43b2ba34fc1cf18239ed807561e00c4a","ref":"refs/heads/pf/gltfio-fix-extended-default-color","pushedAt":"2024-06-10T22:02:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"gltfio: [extended] Fix generated color default\n\nFixes: 7905","shortMessageHtmlLink":"gltfio: [extended] Fix generated color default"}},{"before":"60dafe94ab7f7f0b881262f9b03efb57c0cbdca4","after":null,"ref":"refs/heads/pf/fix-material-pending-edits","pushedAt":"2024-06-10T21:32:50.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"}},{"before":"682150ceec4dc886c1602fb281422b8966debe01","after":"9917d4b7d9466b3add2018f0518b8febb55e7bff","ref":"refs/heads/main","pushedAt":"2024-06-10T21:32:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Null out pending edits once latched (#7916)\n\nOtherwise, we'd keep swapping between the edited version and the\r\noriginal, causing matdbg to not work.","shortMessageHtmlLink":"Null out pending edits once latched (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2344797313\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/filament/issues/7916\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/filament/pull/7916/hovercard\" href=\"https://github.com/google/filament/pull/7916\">#7916</a>)"}},{"before":"522fc684f7fed3d610c834020c1a79d1102cc827","after":"60dafe94ab7f7f0b881262f9b03efb57c0cbdca4","ref":"refs/heads/pf/fix-material-pending-edits","pushedAt":"2024-06-10T21:11:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Merge branch 'main' into pf/fix-material-pending-edits","shortMessageHtmlLink":"Merge branch 'main' into pf/fix-material-pending-edits"}},{"before":"2282c0817a8814fc184a028ca2392e86f8398139","after":"9c46dcc8c6270698a8020538b75132d143638255","ref":"refs/heads/ma/descriptor-sets","pushedAt":"2024-06-10T21:09:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"vk: build new descriptor set framework","shortMessageHtmlLink":"vk: build new descriptor set framework"}},{"before":"0642c88933d5b403dfc12cb4de01b3b921bee77b","after":"522fc684f7fed3d610c834020c1a79d1102cc827","ref":"refs/heads/pf/fix-material-pending-edits","pushedAt":"2024-06-10T20:46:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Null out pending edits once latched\n\nOtherwise, we'd keep swapping between the edited version and the\noriginal, causing matdbg to not work.","shortMessageHtmlLink":"Null out pending edits once latched"}},{"before":null,"after":"0642c88933d5b403dfc12cb4de01b3b921bee77b","ref":"refs/heads/pf/fix-material-pending-edits","pushedAt":"2024-06-10T20:43:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"Null out pending edits once latched\n\nOtherwise, we'd keep swapping between the edited version and the\noriginal, causing matdbg to not work.","shortMessageHtmlLink":"Null out pending edits once latched"}},{"before":"3cc3caecc200ed59d5fd9f4310375662b70ff126","after":"9dad9675dccc811e4f33a03d310ac2bd2e1ced55","ref":"refs/heads/ma/morphing","pushedAt":"2024-06-10T20:31:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"repair extended asset loader for morphing","shortMessageHtmlLink":"repair extended asset loader for morphing"}},{"before":"32e065f9bdd2a147e7712d9d7043f7dc210635f8","after":null,"ref":"refs/heads/ma/debug-disable-subpasses","pushedAt":"2024-06-10T20:19:00.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"}},{"before":"af2ecf201f5b9116cba84d0c6ca0593fae1d52f1","after":"682150ceec4dc886c1602fb281422b8966debe01","ref":"refs/heads/main","pushedAt":"2024-06-10T20:18:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"add debug option to disable sub-passes","shortMessageHtmlLink":"add debug option to disable sub-passes"}},{"before":"bcca3cb3d3594796d8c2ddbbeba377dceb5710d3","after":"3cc3caecc200ed59d5fd9f4310375662b70ff126","ref":"refs/heads/ma/morphing","pushedAt":"2024-06-10T20:18:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"repair extended asset loader for morphing","shortMessageHtmlLink":"repair extended asset loader for morphing"}},{"before":"a655a9d25979f1dcb9de61f3ca0de1bfc2914fc9","after":"32e065f9bdd2a147e7712d9d7043f7dc210635f8","ref":"refs/heads/ma/debug-disable-subpasses","pushedAt":"2024-06-10T19:47:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"add debug option to disable sub-passes","shortMessageHtmlLink":"add debug option to disable sub-passes"}},{"before":"5f1e9dc513b86f13f21825df6380ed3df3a25e8e","after":"bcca3cb3d3594796d8c2ddbbeba377dceb5710d3","ref":"refs/heads/ma/morphing","pushedAt":"2024-06-07T23:25:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"repair extended asset loader for morphing","shortMessageHtmlLink":"repair extended asset loader for morphing"}},{"before":null,"after":"a655a9d25979f1dcb9de61f3ca0de1bfc2914fc9","ref":"refs/heads/ma/debug-disable-subpasses","pushedAt":"2024-06-07T22:20:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"add debug option to disable sub-passes","shortMessageHtmlLink":"add debug option to disable sub-passes"}},{"before":"5404f8ac9b2dbce69a3b85fe1142145df31cf461","after":"2282c0817a8814fc184a028ca2392e86f8398139","ref":"refs/heads/ma/descriptor-sets","pushedAt":"2024-06-07T21:32:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"vk: build new descriptor set framework","shortMessageHtmlLink":"vk: build new descriptor set framework"}},{"before":"5900c24a72345314e0bc3dd84930d1fa9c0a8655","after":"5404f8ac9b2dbce69a3b85fe1142145df31cf461","ref":"refs/heads/ma/descriptor-sets","pushedAt":"2024-06-07T18:19:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"generate the proper per-view descriptor-set layout in the shader\n\nthe per-view descriptor-set layout depends on both the material\nand the variant.","shortMessageHtmlLink":"generate the proper per-view descriptor-set layout in the shader"}},{"before":"7bdb7a41f824444d40c3c3a87067515ce55a3f9a","after":null,"ref":"refs/heads/pf/vk-fix-adreno-ext-name","pushedAt":"2024-06-07T17:29:38.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"}},{"before":"020668733a1a1104a232c6cfef8d338a8a21915b","after":"af2ecf201f5b9116cba84d0c6ca0593fae1d52f1","ref":"refs/heads/main","pushedAt":"2024-06-07T17:29:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"vk: workaround extension name length = 0 (adreno) (#7910)","shortMessageHtmlLink":"vk: workaround extension name length = 0 (adreno) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339299789\" data-permission-text=\"Title is private\" data-url=\"https://github.com/google/filament/issues/7910\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/google/filament/pull/7910/hovercard\" href=\"https://github.com/google/filament/pull/7910\">#7910</a>)"}},{"before":"176133b2d11cb081147f7e027581b58e6535c655","after":"5f1e9dc513b86f13f21825df6380ed3df3a25e8e","ref":"refs/heads/ma/morphing","pushedAt":"2024-06-07T16:43:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"switch to new morphing API\n\n- remove deprecated morphing APIs\n- repair gltfio, samples and tests\n\nThe new API doesn't allow a MorphTargetBuffer per RenderPrimitive,\ninstead the MorphTargetBuffer is specified per Renderable.\n\ngltfio separates RenderPrimitives from Renderables, in particular all\nRenderPrimitives are created before their Renderable; this was\nproblematic for this change because all primitives must share\na single MorphTargetBuffer living in the Renderable.\n\nTo fix this, we're no longer initializing the morphing paramters\nat RenderPrimitive creation, instead we store a reference to the\nBufferSlot in the Primtive structure, so that later, when the Renderable\nis created we can finally retrieve the BufferSlot and initialize its\nmorphing paramters, which are not available. The \"morphing parameters\"\nare now expanded to contain the MorphTargetBuffer as before (except now\nit's always the same for all the primitives of a Rendrable), as well\nas the offset within the buffer and the vertex count.\n\ncaveat: this PR breaks the \"extended\" AssetLoader","shortMessageHtmlLink":"switch to new morphing API"}},{"before":null,"after":"176133b2d11cb081147f7e027581b58e6535c655","ref":"refs/heads/ma/morphing","pushedAt":"2024-06-07T06:00:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"switch to new morphing API\n\n- remove deprecated morphing APIs\n- repair gltfio, samples and tests\n\nThe new API doesn't allow a MorphTargetBuffer per RenderPrimitive,\ninstead the MorphTargetBuffer is specified per Renderable.\n\ngltfio separates RenderPrimitives from Renderables, in particular all\nRenderPrimitives are created before their Renderable; this was\nproblematic for this change because all primitives must share\na single MorphTargetBuffer living in the Renderable.\n\nTo fix this, we're no longer initializing the morphing paramters\nat RenderPrimitive creation, instead we store a reference to the\nBufferSlot in the Primtive structure, so that later, when the Renderable\nis created we can finally retrieve the BufferSlot and initialize its\nmorphing paramters, which are not available. The \"morphing parameters\"\nare now expanded to contain the MorphTargetBuffer as before (except now\nit's always the same for all the primitives of a Rendrable), as well\nas the offset within the buffer and the vertex count.\n\ncaveat: this PR breaks the \"extended\" AssetLoader","shortMessageHtmlLink":"switch to new morphing API"}},{"before":null,"after":"7bdb7a41f824444d40c3c3a87067515ce55a3f9a","ref":"refs/heads/pf/vk-fix-adreno-ext-name","pushedAt":"2024-06-06T23:29:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"poweifeng","name":"Powei Feng","path":"/poweifeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/48371888?s=80&v=4"},"commit":{"message":"vk: workaround extension name length = 0 (adreno)","shortMessageHtmlLink":"vk: workaround extension name length = 0 (adreno)"}},{"before":"e7eb71855368491511522a78395c728d0323c353","after":"5900c24a72345314e0bc3dd84930d1fa9c0a8655","ref":"refs/heads/ma/descriptor-sets","pushedAt":"2024-06-05T23:34:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"finally the per-view descriptors are no longer hardcoded","shortMessageHtmlLink":"finally the per-view descriptors are no longer hardcoded"}},{"before":"0b72b7da4d8799cd076b8c5940f9178d24b8655b","after":"e7eb71855368491511522a78395c728d0323c353","ref":"refs/heads/ma/descriptor-sets","pushedAt":"2024-06-05T23:17:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"pixelflinger","name":"Mathias Agopian","path":"/pixelflinger","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1240896?s=80&v=4"},"commit":{"message":"finally the per-view descriptors are no longer hardcoded","shortMessageHtmlLink":"finally the per-view descriptors are no longer hardcoded"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYpXoTwA","startCursor":null,"endCursor":null}},"title":"Activity · google/filament"}