Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleLiterals pass "constant" backing array to other syntax. #6682

Closed
1 task done
Moderocky opened this issue May 10, 2024 · 0 comments
Closed
1 task done

SimpleLiterals pass "constant" backing array to other syntax. #6682

Moderocky opened this issue May 10, 2024 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Moderocky
Copy link
Member

Skript/Server Version

2.8.5

Bug Description

Simple literals store their value in a backing array, this is passed as-is in getArray, etc. and so any badly-formed syntax that takes the Object[] from getArray and uses it to exchange data could permanently modify the literal value.

Expected Behavior

Probably shouldn't pass the backing array here.

Steps to Reproduce

:(

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@Moderocky Moderocky added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). PR available Issues which have a yet-to-be merged PR resolving it labels May 10, 2024
@Moderocky Moderocky mentioned this issue May 10, 2024
Merged
@Moderocky Moderocky added completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels May 10, 2024
@sovdeeth sovdeeth removed the PR available Issues which have a yet-to-be merged PR resolving it label May 13, 2024
@sovdeeth sovdeeth closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sovdeeth @Moderocky