-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
large_smoke particle generates error on Paper/Spigot 1.20.6 #6635
Comments
Is vault/your economy provider working correctly on those versions? |
According to my logs,
I find no evidence in various places that |
Thanks for the logs. There were many internal changes with 1.20.5/1.20.6 so these may have been something missed on our end. I'll look into it this week and get back to you 🙂 |
|
Yep I confirmed it's still present in the particle entries. Some particles were removed so it could be something going wrong in the particle system. |
My economy plugins is Essentials, but Essentials is still broken on MC 1.20.5. I loaded EssentialsX build 81 to test, and that resolved the So only the |
Don't think I read it right on discord but
that syntax won't work if skript has nothing to work with |
As noted in my previous comment ... mea culpa. When I loaded Essentials (although broken), it worked enough to satisfy Vault and the Skript economy commands. |
Error is still present in Skript 2.9.0-beta1 |
yeah the beta doesn't have any additional bug fixes compared to 2.8.5 |
I've completed my investigation and begun work on a fix. There were just a lot of changes to the Particle Enum that were not addressed in the initial 1.20.5 support PR. I'll have a PR open soon. |
I've opened PR #6716 which should resolve this issue. It is based on 2.8.5 (really, the upcoming 2.8.6 which just includes a few other fixes) If you test it, let me know if you have any issues. You can download the artifact from here: https://github.com/SkriptLang/Skript/actions/runs/9212689747 (direct link: https://github.com/SkriptLang/Skript/actions/runs/9212689747/artifacts/1532145115) |
I'm running Skript 2.9.0-beta1. I am not included to go back, unless you advise. |
I might be able to make a version that is based on 2.9. I'll update here when I am able to. |
This should be fixed in 2.8.6. It will be included in the dev/feature (2.9.0) builds soon. |
Skript/Server Version
Bug Description
The following constructs fail to parse on Paper/Spigot 1.20.5 or 1.20.6
UPDATE: The economy constructs work correctly when Essentials is installed as the economy provider.
Expected Behavior
Those constructs used to parse correctly, prior to Paper/Spigot 1.20.5
Steps to Reproduce
Errors or Screenshots
Other
No response
Agreement
The text was updated successfully, but these errors were encountered: